Skip to content

Flexible array members: make type checking aware and fix bounds checking #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

Flexible array members: make type checking aware and fix bounds checking #6788

merged 1 commit into from
May 31, 2022

Conversation

tautschnig
Copy link
Collaborator

Type checking must be ready to handle type changes between declaration
and definition, which b16c7d7 introduced. Also, bounds checking must
not use size_of_expr with these as 24eba85 rightly introduced a
distinction between "sizeof" and the actual object size as mandated by
the C standard.

Fixes: #6787

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from kroening as a code owner April 7, 2022 22:03
@tautschnig tautschnig requested a review from chris-ryder as a code owner April 7, 2022 22:03
@tautschnig tautschnig mentioned this pull request Apr 7, 2022
Closed
@tautschnig tautschnig self-assigned this Apr 8, 2022
@tautschnig tautschnig force-pushed the bugfixes/6787-flexible-array branch from da0c44a to 3f9754b Compare April 9, 2022 18:36
@tautschnig tautschnig removed their assignment Apr 9, 2022
@codecov
Copy link

codecov bot commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #6788 (22bd66f) into develop (c5f0f36) will increase coverage by 0.00%.
The diff coverage is 96.00%.

@@           Coverage Diff            @@
##           develop    #6788   +/-   ##
========================================
  Coverage    77.00%   77.00%           
========================================
  Files         1594     1594           
  Lines       184350   184371   +21     
========================================
+ Hits        141957   141983   +26     
+ Misses       42393    42388    -5
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.cpp 80.69% <95.23%> (+2.36%) ⬆️
src/ansi-c/goto_check_c.cpp 91.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b81b2...22bd66f. Read the comment docs.

@tautschnig
Flexible array members: make type checking aware and fix bounds checking
22bd66f 
Type checking must be ready to handle type changes between declaration
and definition, which b16c7d7 introduced. Also, bounds checking must
not use `size_of_expr` with these as 24eba85 rightly introduced a
distinction between "sizeof" and the actual object size as mandated by
the C standard.

Fixes: diffblue#6787
@tautschnig tautschnig force-pushed the bugfixes/6787-flexible-array branch from 3f9754b to 22bd66f Compare April 20, 2022 09:43
@kroening kroening merged commit e92c0cc into diffblue:develop May 31, 2022
@tautschnig tautschnig deleted the bugfixes/6787-flexible-array branch June 1, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NlightNFotis NlightNFotis NlightNFotis left review comments

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@chris-ryder chris-ryder Awaiting requested review from chris-ryder

Assignees

@kroening kroening

@chris-ryder chris-ryder

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CBMC error if variable of type struct with flexible array member is forward declared and initialized
5 participants
@tautschnig @kroening @NlightNFotis @peterschrammel @chris-ryder